From 3f18689c2b6791d28a0d670be2292e3083ce286e Mon Sep 17 00:00:00 2001 From: Leonid Pospelov Date: Thu, 19 Jan 2023 03:35:52 +0600 Subject: [PATCH] [node-api] Fix MacOS linking errors (#29013) * fix * add version --- ports/node-api/unofficial-node-api-config.cmake | 6 ++++++ ports/node-api/vcpkg.json | 1 + versions/baseline.json | 2 +- versions/n-/node-api.json | 5 +++++ 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ports/node-api/unofficial-node-api-config.cmake b/ports/node-api/unofficial-node-api-config.cmake index 2ca291a33c..f38708ae6e 100644 --- a/ports/node-api/unofficial-node-api-config.cmake +++ b/ports/node-api/unofficial-node-api-config.cmake @@ -13,6 +13,12 @@ set_target_properties(unofficial::node-api::node-api PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "${node-api_INCLUDE_DIR}" ) +if(APPLE) + set_target_properties(unofficial::node-api::node-api PROPERTIES + INTERFACE_LINK_OPTIONS "LINKER:SHELL:-undefined dynamic_lookup" + ) +endif() + if(WIN32) find_library(node-api_LIBRARY_RELEASE NAMES node PATHS "${CMAKE_CURRENT_LIST_DIR}/../../lib" NO_DEFAULT_PATH REQUIRED) find_library(node-api_LIBRARY_DEBUG NAMES node PATHS "${CMAKE_CURRENT_LIST_DIR}/../../debug/lib" NO_DEFAULT_PATH REQUIRED) diff --git a/ports/node-api/vcpkg.json b/ports/node-api/vcpkg.json index 2f042f3fca..66ebfd474e 100644 --- a/ports/node-api/vcpkg.json +++ b/ports/node-api/vcpkg.json @@ -1,6 +1,7 @@ { "name": "node-api", "version-semver": "18.12.1", + "port-version": 1, "description": "NodeJS API for writing modules in C++", "homepage": "https://nodejs.org/api/addons.html", "license": null, diff --git a/versions/baseline.json b/versions/baseline.json index 36d9fd8bad..7a7bd5ace0 100644 --- a/versions/baseline.json +++ b/versions/baseline.json @@ -5346,7 +5346,7 @@ }, "node-api": { "baseline": "18.12.1", - "port-version": 0 + "port-version": 1 }, "nonius": { "baseline": "2019-04-20", diff --git a/versions/n-/node-api.json b/versions/n-/node-api.json index f276a04039..0df4207ac9 100644 --- a/versions/n-/node-api.json +++ b/versions/n-/node-api.json @@ -1,5 +1,10 @@ { "versions": [ + { + "git-tree": "1b12126f91686d77b2ea46cd9c7e311f000f7bb9", + "version-semver": "18.12.1", + "port-version": 1 + }, { "git-tree": "174e2ac98335fd5510219bd9e0b550b51ce14ee3", "version-semver": "18.12.1",