Global
/
vcpkg
mirror of https://github.com/microsoft/vcpkg.git
1
0
Fork 0
Code Activity

[skills] Pass header files to `vcpkg_install_copyright` when no separate license notice exists (#53107)

This commit is contained in:
Victor Romero 2026-07-29 14:19:07 -07:00 committed by GitHub
parent fd3dde7790
commit e4300a9a73
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/skills/shared/review-vcpkg-pr-guide.md vendored
View File

@ -53,7 +53,7 @@ The report considers the following in particular:
- Autotools `--with-*` / `--enable-*`
11. There is no vendored 3rd party code used during a port's build. The report should list any well known 3rd party libraries found in extracted sources, if any.
12. The versioning scheme in vcpkg.json matches the packaged content.
13. The license declaration in vcpkg.json matches the content installed by installing a port. Note that content in sources may be skipped in settings in portfile.cmake. If a feature in vcpkg.json installs additional content under a different license, then the feature should have a separate license declared. Treat `"license": null` as an intentional declaration that no SPDX expression is available; inspect the copyright file and installed content instead.
13. The license declaration in vcpkg.json matches the content installed by installing a port. Note that content in sources may be skipped in settings in portfile.cmake. If a feature in vcpkg.json installs additional content under a different license, then the feature should have a separate license declared. Treat `"license": null` as an intentional declaration that no SPDX expression is available; inspect the copyright file and installed content instead. When the only available license or copyright notice for a library appears in its header files, patches pass one representative header containing the notice directly to `vcpkg_install_copyright(FILE_LIST ...)`. Do not create a separate text file that copies or extracts the notice from the header.
14. The generated "usage text" is brief and accurate.
15. Ports do not use applications which modify the user's system like sudo, apt, brew, etc.
16. Changes in shared build helpers or `scripts/cmake` that affect many ports need explicit justification for why a global change is necessary. Do not edit frozen `scripts/cmake` helpers when a corresponding `vcpkg-*` helper port exists; require ports to adopt the helper port instead.

1
.gitignore vendored
View File

@ -12,6 +12,7 @@
*.sln.docstates
/vcpkg.json
/vcpkg-configuration.json
reviews*
# fuzzing
sync_dir*