mirror of https://github.com/microsoft/vcpkg.git
ae76307e4b
* Audit use of TO_NATIVE_PATH. TO_NATIVE_PATH should only be used when (1) pasting a path into a command line, or (2) displaying a path to a user. It must not be used before calling other CMake operations like file(WRITE. Fixes https://github.com/microsoft/vcpkg/issues/26178 ports/ffmpeg/portfile.cmake: Both uses are being embedded into a command line ✅ ports/gdal/dependency_win.cmake 117: This used TO_NATIVE_PATH but didn't actually connect the result. It's going on a command line so TO_NATIVE_PATH is appropriate. Drive by: Added quotes around other uses (all of which seem to be going to command lines). 202: ${EXPAT_LIBRARY_REL} ${ZLIB_LIBRARY_REL} don't seem to be set even though they are used; I think this is wrong but I don't know for sure that it is so I'm leaving it alone for now. ports/msmpi/portfile.cmake All 3 uses are being embedded into a command line ✅ ports/jemalloc/fix-utilities.patch ports/libproxy/fix-dependency-libmodman.patch ports/qtbase/env.patch These are in upstream content / context so it is not edited. ports/opengl/portfile.cmake Broken! Drive by fixes: * Modernized checking VCPKG_BUILD_TYPE * Ordered things consistently to be release then debug. * Removed funny newlines. ports/openni2/portfile.cmake Borderline OK; it goes into an MSBuild / vcxproj. I'm leaving it alone. Drive by fixes: * Guarded debug-only copies for VCPKG_BUILD_TYPE * Fixed supports expression ports/openssl/unix/CMakeLists.txt: Unused! ports/pthreads/portfile.cmake: Both uses are being embedded into a command line ✅ ports/qt5-base/cmake/qt_fix_makefile_install.cmake I'm not sure if this one is OK but it's being embedded into a file so it's probably fine. ports/qtapplicationmanager/portfile.cmake: I'm pretty sure this one is wrong, but it's guarded by VCPKG_TARGET_IS_WINDOWS so the ability to create damage is limited. ports/readosm/portfile.cmake: The use is being embedded into a command line ✅ ports/spatialite-tools/portfile.cmake: The use is being embedded into a command line ✅ ports/sqlcipher/portfile.cmake: Both uses are being embedded into a command line ✅ scripts/ports.cmake: Some uses were unused, others are immediately used and printed to the console. ✅ scripts/buildsystems/vcpkg.cmake: Fixed :) scripts/cmake/vcpkg_build_qmake: Looks unused. scripts/cmake/vcpkg_build_process.cmake: Added to console message only. ✅ scripts/cmake/vcpkg_execute_required_process_repeat.cmake: Added to console message only. ✅ Drive by: Fixed typo in variable name in the message. scripts/cmake/vcpkg_execute_required_process.cmake: Added to console message only. ✅ * Fix missing license. |
||
|---|---|---|
| .. | ||
| execute_process.cmake | ||
| vcpkg_acquire_msys.cmake | ||
| vcpkg_add_to_path.cmake | ||
| vcpkg_apply_patches.cmake | ||
| vcpkg_backup_restore_env_vars.cmake | ||
| vcpkg_build_cmake.cmake | ||
| vcpkg_build_make.cmake | ||
| vcpkg_build_msbuild.cmake | ||
| vcpkg_build_ninja.cmake | ||
| vcpkg_build_nmake.cmake | ||
| vcpkg_build_qmake.cmake | ||
| vcpkg_buildpath_length_warning.cmake | ||
| vcpkg_check_features.cmake | ||
| vcpkg_check_linkage.cmake | ||
| vcpkg_clean_executables_in_bin.cmake | ||
| vcpkg_clean_msbuild.cmake | ||
| vcpkg_common_definitions.cmake | ||
| vcpkg_common_functions.cmake | ||
| vcpkg_configure_cmake.cmake | ||
| vcpkg_configure_gn.cmake | ||
| vcpkg_configure_make.cmake | ||
| vcpkg_configure_meson.cmake | ||
| vcpkg_configure_qmake.cmake | ||
| vcpkg_copy_pdbs.cmake | ||
| vcpkg_copy_tool_dependencies.cmake | ||
| vcpkg_copy_tools.cmake | ||
| vcpkg_download_distfile.cmake | ||
| vcpkg_execute_build_process.cmake | ||
| vcpkg_execute_in_download_mode.cmake | ||
| vcpkg_execute_required_process.cmake | ||
| vcpkg_execute_required_process_repeat.cmake | ||
| vcpkg_extract_source_archive.cmake | ||
| vcpkg_extract_source_archive_ex.cmake | ||
| vcpkg_fail_port_install.cmake | ||
| vcpkg_find_acquire_program.cmake | ||
| vcpkg_find_fortran.cmake | ||
| vcpkg_fixup_cmake_targets.cmake | ||
| vcpkg_fixup_pkgconfig.cmake | ||
| vcpkg_from_bitbucket.cmake | ||
| vcpkg_from_git.cmake | ||
| vcpkg_from_github.cmake | ||
| vcpkg_from_gitlab.cmake | ||
| vcpkg_from_sourceforge.cmake | ||
| vcpkg_get_program_files_platform_bitness.cmake | ||
| vcpkg_get_windows_sdk.cmake | ||
| vcpkg_host_path_list.cmake | ||
| vcpkg_install_cmake.cmake | ||
| vcpkg_install_copyright.cmake | ||
| vcpkg_install_gn.cmake | ||
| vcpkg_install_make.cmake | ||
| vcpkg_install_meson.cmake | ||
| vcpkg_install_msbuild.cmake | ||
| vcpkg_install_nmake.cmake | ||
| vcpkg_install_qmake.cmake | ||
| vcpkg_list.cmake | ||
| vcpkg_minimum_required.cmake | ||
| vcpkg_replace_string.cmake | ||
| vcpkg_test_cmake.cmake | ||
| z_vcpkg_apply_patches.cmake | ||
| z_vcpkg_escape_regex_control_characters.cmake | ||
| z_vcpkg_fixup_rpath.cmake | ||
| z_vcpkg_forward_output_variable.cmake | ||
| z_vcpkg_function_arguments.cmake | ||
| z_vcpkg_get_cmake_vars.cmake | ||
| z_vcpkg_prettify_command_line.cmake | ||
| z_vcpkg_setup_pkgconfig_path.cmake | ||